#141680: "incorrect score display"
O čom je toto hlásenie?
Čo sa stalo? Prosím vyber z nasledujúcich
Čo sa stalo? Prosím vyber z nasledujúcich
Prosím skontroluj, či už existuje hlásenie na rovnakú tému
Ak je to tak, prosím HLASUJTE za toto hlásenie. Hlásenia s najviac hlasmi majú PRIORITU!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Podrobný popis
-
• Prosím skopíruj a vlož chybové hlásenie, ktoré si videl na obrazovke, ak sa nejaké vyskytlo.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Prosím vysvetli, čo si chcel/a spraviť, čo si spravil/a a čo sa stalo
• Aký prehliadač používaš?
opera
-
• Skopíruj/vlož text zobrazený v angličtine namiesto tvojho jazyka. Ak máš screenshot (dobrý zvyk), môžeš použiť Imgur.com na jeho nahranie a skopírovať sem odkaz na neho.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Je tento text dostupný v prekladovom systéme? Ak áno, bol preložený po dlhšie ako 24 hodín?
• Aký prehliadač používaš?
opera
-
• Prosím presne a stručne vysvetli svoj podnet, aby bolo čo najjednoduchšie pochopiť, ako to myslíš.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Aký prehliadač používaš?
opera
-
• Čo sa objavilo na obrazovke, keď si bol zablokovaný (Prázdna obrazovka? Časť herného rozhrania? Chybové hlásenie?)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Aký prehliadač používaš?
opera
-
• Ktorá časť pravidiel nebola dodržaná v BGA adaptácii?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Je možné vidieť porušenie pravidiel na zázname z hry? Ak áno, aké je číslo ťahu?
• Aký prehliadač používaš?
opera
-
• Aký herný ťah si chcel urobiť?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Čo si skúsil aby si vyvolal túto akciu?
-
• Čo sa stalo keď si spravil túto hernú akciu (chybové hlásenie, hlásenie v stavovom pruhu, ...)?
• Aký prehliadač používaš?
opera
-
• Kedy v priebehu hry sa problém vyskytol (aká bola prebiehajúca herná inštrukcia)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Čo sa stalo keď si spravil túto hernú akciu (chybové hlásenie, hlásenie v stavovom pruhu, ...)?
• Aký prehliadač používaš?
opera
-
• Prosím popíš viditeľný problém. Ak máš screenshot (dobrý zvyk), môžeš použiť Imgur.com na jeho nahranie a skopírovať sem odkaz na neho.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Aký prehliadač používaš?
opera
-
• Skopíruj/vlož text zobrazený v angličtine namiesto tvojho jazyka. Ak máš screenshot (dobrý zvyk), môžeš použiť Imgur.com na jeho nahranie a skopírovať sem odkaz na neho.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Je tento text dostupný v prekladovom systéme? Ak áno, bol preložený po dlhšie ako 24 hodín?
• Aký prehliadač používaš?
opera
-
• Prosím presne a stručne vysvetli svoj podnet, aby bolo čo najjednoduchšie pochopiť, ako to myslíš.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• Aký prehliadač používaš?
opera
História hlásenia
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Pridať niečo k tomuto hláseniu
- Iné ID stola / ID ťahu
- Vyriešil sa problém pomocou F5?
- Objavil sa problém viackrát? Zakaždým? Náhodne?
- Ak máš screenshot (dobrý zvyk), môžeš použiť Imgur.com na jeho nahranie a skopírovať sem odkaz na neho.
